fix: fixes anvil-zksync failing on ubuntu-latest #527
Merged
+20
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
reviewed
Jan 10, 2025
.github/workflows/release.yml
Outdated
| @@ -41,9 +41,9 @@ jobs: | |||
| ] | |||
| include: | |||
| - arch: x86_64-unknown-linux-gnu | |||
| platform: ubuntu-20.04 | |||
| platform: ubuntu-latest | |||
There was a problem hiding this comment.
Not sure if it's a good idea, using latest recently broke CI in one of other repositories. IMHO it's better to avoid unexpected changes.
itegulov
reviewed
Jan 10, 2025
| make build-static-${{ matrix.arch }} | ||
| else | ||
| make build-${{ matrix.arch }} | ||
| fi |
There was a problem hiding this comment.
Do you think we shouldn't build static binaries on macOS? I assume openssl is more or less on every modern mac machine but I wouldn't count on it being the same version
There was a problem hiding this comment.
I am not too familiar with any pros / cons but figured we havent had any issue with the macos builds to leave it as it. When I was looking into static builds it seems only prevalent with linux builds.
itegulov
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
anvil-zksyncfails onubuntu-latestdue to missinglibssl.so.1.1#524Why ✋
anvil-zksyncfails onubuntu-latestdue to missinglibssl.so.1.1#524Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intended